Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lang): migrate outdated plural definitions #12784

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix(lang): migrate outdated plural definitions #12784

merged 1 commit into from
Oct 15, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Oct 15, 2024

Proposed changes

  • remove duplicate CLDR or Qt plurals
  • update CLDR with zero formulas

Fixes #12695

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel
fix(lang): migrate outdated plural definitions
f65fec6 
- remove duplicate CLDR or Qt plurals
- update CLDR with zero formulas

Fixes WeblateOrg#12695
@nijel nijel added this to the 5.8.2 milestone Oct 15, 2024
@nijel nijel self-assigned this Oct 15, 2024
@nijel nijel enabled auto-merge (rebase) October 15, 2024 13:26
@nijel nijel mentioned this pull request Oct 15, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.83333% with 19 lines in your changes missing coverage. Please review.

Project coverage is 91.17%. Comparing base (a3c2d47) to head (f65fec6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
weblate/lang/models.py 20.83% 17 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #12784       +/-   ##
===========================================
+ Coverage   24.20%   91.17%   +66.96%     
===========================================
  Files         596      596               
  Lines       61110    61132       +22     
  Branches     6336     6343        +7     
===========================================
+ Hits        14791    55736    +40945     
+ Misses      46185     3745    -42440     
- Partials      134     1651     +1517
Files with missing lines Coverage Δ
weblate/lang/models.py 88.44% <20.83%> (+45.41%) ⬆️

... and 453 files with indirect coverage changes

@nijel nijel merged commit d9432e4 into WeblateOrg:main Oct 15, 2024
35 of 37 checks passed
@nijel nijel deleted the plurals-migrate branch October 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangesunny orangesunny Awaiting requested review from orangesunny orangesunny is a code owner

Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
5.8.2
Development

Successfully merging this pull request may close these issues.

Incorrect plural information in "CLDR plural with zero"
1 participant
@nijel